Encode urls for css background images #7906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the encode urls utility to encode all background images in css
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7906 +/- ##
==========================================
+ Coverage 56.91% 57.44% +0.53%
==========================================
Files 676 677 +1
Lines 27370 27373 +3
Branches 2688 2689 +1
==========================================
+ Hits 15577 15724 +147
+ Misses 11453 11308 -145
- Partials 340 341 +1
... and 22 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
|
||
| await expect(page.getByLabel('Image Wrapper')).toBeVisible(); | ||
| }); | ||
| test.fixme('Can provide a custom image with spaces in name', async ({ page }) => { |
There was a problem hiding this comment.
will fix on otherside
unlikelyzero
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7903
Describe your changes:
Add a utility to encode a url.
Use the encode url utility to encode all background images in css.
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist